module: fix extensionless entry with explicit type=commonjs by inoway46 · Pull Request #61600 · nodejs/node

inoway46 · 2026-01-31T15:24:29Z

When an extensionless entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without executing or showing any error. This happened because extensionless files skip the .js suffix check in the CJS loader, so the explicit type: commonjs was not being enforced, allowing ESM syntax to be silently delegated to ESM loading which never completed before the process exited.

This change ensures the CJS loader treats extensionless entry points as commonjs when type is explicitly set to "commonjs" in package.json, forcing ESM syntax to surface as a SyntaxError instead of silently exiting.

Fixes: #61104

Related: #61171 (alternative approach)

nodejs-github-bot · 2026-01-31T15:24:34Z

Review requested:

@nodejs/loaders

joyeecheung

Thanks for the PR, a couple of comments, otherwise this looks good.

test/es-module/test-extensionless-esm-type-commonjs.js

lib/internal/modules/cjs/loader.js

test/es-module/test-extensionless-esm-type-commonjs.js

nodejs-github-bot · 2026-02-07T11:43:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71228/

codecov · 2026-02-07T12:42:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (f6464c5) to head (79d60d5).
⚠️ Report is 123 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61600      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.03%     
==========================================
  Files         673      675       +2     
  Lines      203944   204538     +594     
  Branches    39191    39307     +116     
==========================================
+ Hits       183080   183553     +473     
- Misses      13194    13297     +103     
- Partials     7670     7688      +18

Files with missing lines	Coverage Δ
lib/internal/modules/cjs/loader.js	`98.36% <100.00%> (+0.19%)`	⬆️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

inoway46 · 2026-02-07T13:30:22Z

Thanks for the approval.
I pushed a small lint follow-up: I added require('../common') at the top of test/es-module/test-extensionless-esm-type-commonjs.js to satisfy the required module ordering rules.

I also verified make lint-js locally for the changed JS files.
Could you please rerun CI if needed? Thank you.

lib/internal/modules/cjs/loader.js

nodejs-github-bot · 2026-02-08T01:00:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71237/

nodejs-github-bot · 2026-02-08T16:45:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71255/

joyeecheung · 2026-02-08T21:27:14Z

@inoway46 Can you squash the commits? I don't think they would pass the test individually.

inoway46 · 2026-02-09T01:57:18Z

I squashed the commits and force-pushed the branch.
The PR now has a single commit: 79d60d5.
Please let me know if you'd like any further changes.

nodejs-github-bot · 2026-02-11T23:34:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71317/

inoway46 · 2026-02-16T06:43:50Z

Friendly ping — this looks ready to land (CI is green and approvals are in place).
Please let me know if there’s anything else I should address from my side.

nodejs-github-bot · 2026-02-16T14:59:00Z

Landed in 4f13746

PR-URL: #61600 Fixes: #61104 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 31, 2026

inoway46 marked this pull request as ready for review January 31, 2026 15:45

inoway46 mentioned this pull request Jan 31, 2026

module: throw error for ESM syntax in explicit commonjs entry #61171

Closed

joyeecheung reviewed Jan 31, 2026

View reviewed changes

test/es-module/test-extensionless-esm-type-commonjs.js Outdated Show resolved Hide resolved

test/es-module/test-extensionless-esm-type-commonjs.js Outdated Show resolved Hide resolved

lib/internal/modules/cjs/loader.js Outdated Show resolved Hide resolved

inoway46 requested a review from joyeecheung February 1, 2026 04:06

joyeecheung reviewed Feb 1, 2026

View reviewed changes

test/es-module/test-extensionless-esm-type-commonjs.js Outdated Show resolved Hide resolved

inoway46 requested a review from joyeecheung February 1, 2026 17:12

joyeecheung reviewed Feb 6, 2026

View reviewed changes

test/es-module/test-extensionless-esm-type-commonjs.js Outdated Show resolved Hide resolved

inoway46 requested a review from joyeecheung February 6, 2026 16:17

joyeecheung approved these changes Feb 7, 2026

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2026

ljharb reviewed Feb 7, 2026

View reviewed changes

lib/internal/modules/cjs/loader.js Show resolved Hide resolved

joyeecheung approved these changes Feb 8, 2026

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026

marco-ippolito approved these changes Feb 8, 2026

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2026

module: fix extensionless entry with explicit type=commonjs

79d60d5

inoway46 force-pushed the fix-extensionless-type-commonjs-esm branch from 601e4c5 to 79d60d5 Compare February 9, 2026 01:55

Qard approved these changes Feb 10, 2026

View reviewed changes

joyeecheung approved these changes Feb 11, 2026

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2026

Qard added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 16, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2026

nodejs-github-bot merged commit 4f13746 into nodejs:main Feb 16, 2026
70 checks passed

Uh oh!

Conversation

inoway46 commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 31, 2026

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 7, 2026

Uh oh!

codecov bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

inoway46 commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 8, 2026

Uh oh!

nodejs-github-bot commented Feb 8, 2026

Uh oh!

joyeecheung commented Feb 8, 2026

Uh oh!

inoway46 commented Feb 9, 2026

Uh oh!

nodejs-github-bot commented Feb 11, 2026

Uh oh!

inoway46 commented Feb 16, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

inoway46 commented Jan 31, 2026 •

edited

Loading

codecov bot commented Feb 7, 2026 •

edited

Loading

inoway46 commented Feb 7, 2026 •

edited

Loading